SNOW-821644 add dataframe alias support #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bli
reviewed
Jan 2, 2024
| @@ -2791,7 +2808,8 @@ class DataFrame private[snowpark] ( | |||
|
|
|||
| // utils | |||
| private[snowpark] def resolve(colName: String): NamedExpression = { | |||
| val normalizedColName = quoteName(colName) | |||
| val (aliasColName, aliasOutput) = resolveAlias(colName, output) | |||
There was a problem hiding this comment.
Can we directly return result form resolveAlias if we can find that name?
There was a problem hiding this comment.
We need to quote the column name and check for name conflicts, so it's better to return the column name and output list.
src/main/scala/com/snowflake/snowpark/internal/analyzer/Expression.scala
Show resolved
Hide resolved
src/main/scala/com/snowflake/snowpark/internal/analyzer/ExpressionAnalyzer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/snowflake/snowpark/internal/analyzer/ExpressionAnalyzer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/snowflake/snowpark/internal/analyzer/ExpressionAnalyzer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/snowflake/snowpark/internal/analyzer/SnowflakePlanNode.scala
Outdated
Show resolved
Hide resolved
sfc-gh-bli
reviewed
Jan 3, 2024
| @@ -192,6 +206,17 @@ private[snowpark] case class Sort(order: Seq[SortOrder], child: LogicalPlan) ext | |||
| Sort(order, _) | |||
| } | |||
|
|
|||
| private[snowpark] case class DataframeAlias(alias: String, child: LogicalPlan) | |||
| extends UnaryNode { | |||
| dfAliasMap += (alias -> child.getSnowflakePlan.get.output) | |||
There was a problem hiding this comment.
override lazy val dfAliasMap = child.dfAliasMap + (alias -> child.getSnowflakePlan.get.output)
sfc-gh-bli
reviewed
Jan 3, 2024
|
|
||
| addToDataframeAliasMap(left) | ||
| addToDataframeAliasMap(right) |
There was a problem hiding this comment.
override lazy val dfAliasMap = left.dfAliasMap ++ right.dfAliasMap
sfc-gh-bli
approved these changes
Jan 3, 2024
src/main/scala/com/snowflake/snowpark/internal/analyzer/SnowflakePlanNode.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/snowflake/snowpark/internal/analyzer/SnowflakePlanNode.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/snowflake/snowpark/internal/analyzer/MultiChildrenNode.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Replace this with a short description of how your code change solves the related issue.
Pre-review checklist
(For Snowflake employees)